Skip to content

Handle tss txp deletion; Add cli session restoration; Bug fixes#4206

Open
kajoseph wants to merge 1 commit into
bitpay:masterfrom
kajoseph:bitcoreCli
Open

Handle tss txp deletion; Add cli session restoration; Bug fixes#4206
kajoseph wants to merge 1 commit into
bitpay:masterfrom
kajoseph:bitcoreCli

Conversation

@kajoseph

@kajoseph kajoseph commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Description

If walletA is in the process of signing a txp and walletB deletes the txp, then walletA will be spinning indefinitely. This PR deletes corresponding TSS signing sessions when deleting a txp. This will cause walletA's session to error with a "Session not found" error, leaving it up to the client to handle appropriately (as seen in CLI).

Furthermore, this PR adds support for TSS session restoration in case a session is interrupted.

Even furthermore, this fixes a couple of CLI bugs.

Changelog

  • Deletes TSS signing sessions with txp removal.
  • Adds TSS signing session restoration.
    • TODO: would be prudent to add a cleanup function to CLI to remove any zombie state files
  • CLI - Fixes tokens not being saved to persistent opts in EVM wallets
  • CLI - Fixes copayer0 of TSS wallets not getting other copayers. This would result in copayer0 being unable to verify txps created by other copayers.

Testing Notes

Add any helpful notes for reviewers to test your code here.


Checklist

  • I have read CONTRIBUTING.md and verified that this PR follows the guidelines and requirements outlined in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant